RFR: 8338011: CDS archived heap object support for 64-bit Windows [v2]

[Ioi Lam]

On Sat, 10 Aug 2024 16:43:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @tstuefe review -- changed error message
>
> src/hotspot/share/cds/filemap.cpp line 2188:
> 
>> 2186:                      /* do_commit = */ true)) {
>> 2187:       dealloc_heap_region();
>> 2188:       log_error(cds)("Failed to read archived heap region at " INTPTR_FORMAT, p2i(addr));
> 
> Very minor bikeshedding, we don't try to read the heap region at this address but load it into memory at that address. Up to you if you change anything.

I changed the message to "Failed to read archived heap region into 0x12345678...". Does that sound better?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20514#discussion_r1713059616