RFR: 8338011: CDS archived heap object support for 64-bit Windows [v2]

[Thomas Stuefe]

On Sun, 11 Aug 2024 21:17:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> We didn't support CDS archived heap object on Windows because
>> 
>> - The Windows implementation of `os::map_memory()` cannot map the contents of a file into a region that's already reserved by the garbage collector.
>> - We had a high failure rate for mapping the CDS archive on Windows due to ASLR, sometimes as high as 50%. So it didn't seem worth the effort (mainly testing) to support archived heap objects on Windows.
>> 
>> Both of the above issues were fixed in [JDK-8231610](https://bugs.openjdk.org/browse/JDK-8231610), so we should add the support to Windows now.
>> 
>> (Tested on Oracle CI tiers 1-7)
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @tstuefe review -- changed error message

This looks good. Thanks for changing the error message.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20514#pullrequestreview-2232620901