RFR: 8338539: New Object to ObjectMonitor mapping: riscv64 implementation [v2]

Robbin Ehn rehn at openjdk.org
Tue Aug 20 07:56:48 UTC 2024


On Mon, 19 Aug 2024 14:28:23 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> The riscv64 implementation of JDK-8315884 New Object to ObjectMonitor mapping
>> 
>> ### Testing:
>> - [x] tier1-3 & hotspot:tier4 tests (release)
>> - [x] test/hotspot/jtreg/runtime/Monitor/UseObjectMonitorTableTest.java (release & fastdebug)
>
> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8338539
>  - 8338539: New Object to ObjectMonitor mapping: riscv64 implementation

Hey, not funcational review yet.

But this code have been patched to many times "let me just add this".
We shadow tmp1 register with tmp1_mark, then we shadow tmp1 with tmp1_monitor.
And similar for other tmp registers.

If we create two methods, one for "{ // Lightweight locking" and one for "{ // Handle inflated monitor." this code will be so much better.

If you are not up for the task I can do it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20621#issuecomment-2298200469


More information about the hotspot-dev mailing list