RFR: 8328880: Events::log_exception should limit the size of the logging message
Aleksey Shipilev
shade at openjdk.org
Tue Aug 20 12:56:52 UTC 2024
On Tue, 20 Aug 2024 05:22:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
> This simple enhancement allows for `Exceptions::_throw` to limit the message length printed by `Events::log_exception` in the same way that unified logging is limited. We simply allow a `message_length_limit` variable to be passed down - default value zero which means no limit (i.e. the full `strlen` of the message will be printed).
>
> Testing:
> - tiers 1-3
>
> Thanks
Looks reasonable. (First time I see `%.*s`, this is a cute trick I did not know about before.)
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20638#pullrequestreview-2247915371
More information about the hotspot-dev
mailing list