RFR: 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds [v2]

Matias Saavedra Silva matsaave at openjdk.org
Thu Aug 22 15:58:10 UTC 2024


On Wed, 21 Aug 2024 19:53:16 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Removed incorrect comment and added copyright
>>  - Added regression test
>
> Let's say the JSR is not the last instruction, but it doesn't return because there is no RET instruction.  What is the effect of creating a basic block that won't be used -- is it harmless?  Do we need a test for that?

Thanks for the reviews @dean-long and @TobiHartmann! And thank you @eme64 for the reproducer!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20645#issuecomment-2305109628


More information about the hotspot-dev mailing list