RFR: 8338539: New Object to ObjectMonitor mapping: riscv64 implementation [v2]

Fei Yang fyang at openjdk.org
Sat Aug 24 13:02:10 UTC 2024


On Tue, 20 Aug 2024 12:37:58 GMT, Gui Cao <gcao at openjdk.org> wrote:

> > Hey, not functional review yet.
> > But this code have been patched to many times "let me just add this". We shadow tmp1 register with tmp1_mark, then we shadow tmp1 with tmp1_monitor. And similar for other tmp registers.
> > If we create two methods, one for "{ // Lightweight locking" and one for "{ // Handle inflated monitor." this code will be so much better.
> > If you are not up for the task I can do it.
> > (your patch actually slightly improves this, so I'm not saying it's your doing)
> 
> Hi, Thanks for having a look! Your suggestion makes sense to me. But I feel that it's better to go with another PR. Will leave it for you :-)

Hi, Please keep the current shape for a while as I am trying to sync regularly with latest loom fiber changes which touches this part.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20621#issuecomment-2308386092


More information about the hotspot-dev mailing list