RFR: 8339030: frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Aug 28 12:33:21 UTC 2024


On Tue, 27 Aug 2024 17:14:38 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Method
>> frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument
>> 
>> it usually is called with nullptr as second arg except
>> JavaThread::trace_frames()
>> where it is called with this.
>> 
>> It seems that thread has never been used since 2007 so makes sense just to get rid of it.
>> 
>> Tested building all builds available in CI and running tier13
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed identation

This looks great.  Thanks for cleaning this up.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20721#pullrequestreview-2266117942


More information about the hotspot-dev mailing list