RFR: 8338018: Rename ClassPrelinker to AOTConstantPoolResolver

Ioi Lam iklam at openjdk.org
Thu Aug 29 05:46:24 UTC 2024


On Thu, 29 Aug 2024 05:22:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This is the 2nd PR for [JEP 483: Ahead-of-Time Class Loading & Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>> 
>> A simple renaming of the `ClassPrelinker` class to `AOTConstantPoolLinker`, so that the name is consistent with new classes that will be introduced in subsequent PRs for JEP 483 (`AOTClassLinker`, `AOTLinkedClassTable`, and `AOTLinkedClassBulkLoader`).
>> 
>> -----
>> See [here](https://bugs.openjdk.org/browse/JDK-8315737) for the sequence of dependent RFEs for implementing JEP 483.
>
> src/hotspot/share/cds/aotConstantPoolResolver.hpp line 42:
> 
>> 40: class Klass;
>> 41: 
>> 42: template <typename T> class GrowableArray;
> 
> This doesn't seem part of the rename.

This header was using GrowableArray without declaring it. The problem is discovered after this header is moved earlier due to alphabetical sorting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20517#discussion_r1735599671


More information about the hotspot-dev mailing list