RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v10]

Fri Aug 30 08:27:23 UTC 2024

On Wed, 28 Aug 2024 08:17:14 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename g1XChgX to g1GetAndSetX for consistency with Ideal operation names
>
> src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp line 229:
> 
>> 227: }
>> 228: 
>> 229: void refine_barrier_by_new_val_type(Node* n) {
> 
> This function should probably be `static`.

Done, thanks (I also made its argument `const`, see commit [29d8a89](https://github.com/openjdk/jdk/pull/19746/commits/29d8a89a9a7fd0c1717330609c6d7cb36b0ff174)).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1738192979