Poisoning in HotSpot

[David Holmes]

On 2/12/2024 2:13 am, Kim Barrett wrote:
> On 12/1/24 10:16 AM, Kim Barrett wrote:
>> On 12/1/24 7:35 AM, Kim Barrett wrote:
>>>
>>> How about this: [code snipped]
>>>
>>
>> I decided I like this enough to work on implementing it.
> 
> Unfortunately, there's a potentially fatal problem with this whole 
> approach.
> We don't have a mechanism for turning it off over some context. We need 
> this
> because there are files that ere not ours that are subject to our headers.
> Consider gtest, for example. Apparently there are *lots* of calls to 
> sprintf,
> for example.
> 
> I've not yet come up with a way for this new mechanism to deal with that.

Somewhat crude but couldn't gtests #define USING_GTEST before including 
our headers and then we could make the forbidden stuff conditional on 
ifndef USING_GTEST. ??

David

> I've also not figured out how things are working now.  Why don't we get 
> lots
> of warnings for those calls to sprintf now?  I would have guessed there was
> some suppression of -Wattribute-warning somewhere, but I'm not finding 
> such.
>