RFR: 8345177: RISC-V: Add gtests for cmpxchg [v2]
Hamlin Li
mli at openjdk.org
Mon Dec 2 12:01:48 UTC 2024
On Fri, 29 Nov 2024 14:01:53 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> This adds tests to some of the base cases.
>> Focusing on the cases when we pass in same register in some of the argument. (variant 0,1,2,3)
>>
>> Note: Google Test filter = *RiscV.cmpxchg*
>> [==========] Running 4 tests from 1 test suite.
>> [----------] Global test environment set-up.
>> [----------] 4 tests from RiscV
>> [ RUN ] RiscV.cmpxchg_int64_plain_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int64_plain_lr_sc_vm (2 ms)
>> [ RUN ] RiscV.cmpxchg_int64_plain_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int64_plain_maybe_zacas_vm (0 ms)
>> [ RUN ] RiscV.cmpxchg_int32_plain_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int32_plain_lr_sc_vm (0 ms)
>> [ RUN ] RiscV.cmpxchg_int32_plain_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int32_plain_maybe_zacas_vm (0 ms)
>> [----------] 4 tests from RiscV (20806 ms total)
>>
>> [----------] Global test environment tear-down
>> [==========] 4 tests from 1 test suite ran. (20809 ms total)
>> [ PASSED ] 4 tests.
>>
>>
>> Executed with `-XX:+UnlockExperimentalVMOptions -XX:+UseZacas`
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove CMF barrier
Thanks for adding the tests. Looks good to me.
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22437#pullrequestreview-2472504311
More information about the hotspot-dev
mailing list