RFR: 8339983: [s390x] secondary_super_cache does not scale well: C1 and interpreter [v4]

[Amit Kumar]

On Wed, 27 Nov 2024 11:23:14 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> s390x Port for : [JDK-8331341](https://bugs.openjdk.org/browse/JDK-8331341)
>> 
>> Tier1 test: 
>> 1. `-XX:+UseSecondarySupersTable  -XX:+VerifySecondarySupers -XX:+VerifySecondarySupers -XX:-UseSecondarySupersCache`
>> 2.  No flag turn on. i.e. used `UseSecondarySupersCache` by default. 
>> 3. `-XX:+UseSecondarySupersTable  -XX:+VerifySecondarySupers -XX:+VerifySecondarySupers -XX:-UseSecondarySupersCache` with C1 compiler
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updates comments

Here are the correct benchmark results: 

make test TEST="micro:vm.compiler.SecondarySuperCacheInterContention"  MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"

Benchmark                                   Mode  Cnt  Score   Error  Units
SecondarySuperCacheInterContention.test     avgt   15  8.201 ± 0.264  ns/op
SecondarySuperCacheInterContention.test:t1  avgt   15  8.181 ± 0.256  ns/op
SecondarySuperCacheInterContention.test:t2  avgt   15  8.221 ± 0.327  ns/op
Finished running test 'micro:vm.compiler.SecondarySuperCacheInterContention'

make test TEST="micro:vm.compiler.SecondarySuperCacheInterContention"  MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1 -XX:+UnlockDiagnosticVMOptions -XX:+UseSecondarySupersCache -XX:-UseSecondarySupersTable"

Benchmark                                   Mode  Cnt     Score     Error  Units
SecondarySuperCacheInterContention.test     avgt   15  1873.536 ± 189.942  ns/op
SecondarySuperCacheInterContention.test:t1  avgt   15  1897.531 ± 175.604  ns/op
SecondarySuperCacheInterContention.test:t2  avgt   15  1849.541 ± 218.214  ns/op
Finished running test 'micro:vm.compiler.SecondarySuperCacheInterContention'



make test TEST="micro:vm.compiler.SecondarySuperCacheIntraContention"  MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"

SecondarySuperCacheIntraContention.test  avgt   15  7.988 ± 0.361  ns/op
Finished running test 'micro:vm.compiler.SecondarySuperCacheIntraContention'


make test TEST="micro:vm.compiler.SecondarySuperCacheIntraContention"  MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1 -XX:+UnlockDiagnosticVMOptions -XX:+UseSecondarySupersCache -XX:-UseSecondarySupersTable"

SecondarySuperCacheIntraContention.test  avgt   15  2780.239 ± 110.116  ns/op
Finished running test 'micro:vm.compiler.SecondarySuperCacheIntraContention'

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22341#issuecomment-2511388077