RFR: 8339983: [s390x] secondary_super_cache does not scale well: C1 and interpreter [v4]
Andrew Haley
aph at openjdk.org
Mon Dec 2 13:27:38 UTC 2024
On Wed, 27 Nov 2024 11:23:14 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> s390x Port for : [JDK-8331341](https://bugs.openjdk.org/browse/JDK-8331341)
>>
>> Tier1 test:
>> 1. `-XX:+UseSecondarySupersTable -XX:+VerifySecondarySupers -XX:+VerifySecondarySupers -XX:-UseSecondarySupersCache`
>> 2. No flag turn on. i.e. used `UseSecondarySupersCache` by default.
>> 3. `-XX:+UseSecondarySupersTable -XX:+VerifySecondarySupers -XX:+VerifySecondarySupers -XX:-UseSecondarySupersCache` with C1 compiler
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> updates comments
Looks good, thanks.
It's probably worth making sure there's a `make bootcycle-images` and if it doesn't take forever, tiers 2-4. We don't want any nasty surprises.
-------------
Marked as reviewed by aph (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22341#pullrequestreview-2472695930
More information about the hotspot-dev
mailing list