RFR: 8344609: Check ResourceMark nesting when allocating a GrowableArray on an alternative ResourceArea [v3]

Richard Reingruber rrich at openjdk.org
Mon Dec 2 13:42:25 UTC 2024


> With this change the GrowableArray nesting check is also performed if allocating from an `Arena` which in fact is a `ResourceArea`.
> 
> The additional checking can help find issue as [JDK-8328085](https://bugs.openjdk.org/browse/JDK-8328085).
> 
> The fix passed our nightly CI testing:
> Tier 1-4 of hotspot and jdk. All of langtools and jaxp. Renaissance Suite and SAP specific tests.
> Testing was done on the main platforms and also on Linux/PPC64le and AIX.
> 
> Besides ctw tests on ppc64 (see [JDK-8328085](https://bugs.openjdk.org/browse/JDK-8328085)) the check never failed.

Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master'
 - Add parentheses
 - Check GrowableArray nesting if allocating on alternative ResourceArea

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22269/files
  - new: https://git.openjdk.org/jdk/pull/22269/files/e00d6154..54749167

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22269&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22269&range=01-02

  Stats: 87557 lines in 1628 files changed: 53712 ins; 25375 del; 8470 mod
  Patch: https://git.openjdk.org/jdk/pull/22269.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22269/head:pull/22269

PR: https://git.openjdk.org/jdk/pull/22269


More information about the hotspot-dev mailing list