RFR: 8339910: RISC-V: crc32 intrinsic with carry-less multiplication [v2]
Andrew Haley
aph at openjdk.org
Mon Dec 2 13:46:40 UTC 2024
On Mon, 2 Dec 2024 12:49:53 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you review this patch to implement CRC32 with `vclmul` (Zvbc)?
>> Thanks!
>>
>>
>> ## Test
>> test/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32.java,
>> test/jdk/java/util/zip/TestCRC32.java
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>
> - minor
> - macros to functions
No further objections from me. It looks fine, but I'm not a RISC V expert so I won't tick the box.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22475#pullrequestreview-2472740972
More information about the hotspot-dev
mailing list