RFR: 8345289: RISC-V: enable some extensions with hwprobe
Hamlin Li
mli at openjdk.org
Mon Dec 2 14:15:17 UTC 2024
On Mon, 2 Dec 2024 10:03:21 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> Hi,
>> Can you help to review the patch?
>> Currently, some extensions are not enable automatically with hwprobe, this is to enable them with hwprobe result.
>>
>> Thanks!
>>
>> Tests running so far so good.
>
> src/hotspot/os_cpu/linux_riscv/riscv_hwprobe.cpp line 184:
>
>> 182: VM_Version::ext_Zfh.enable_feature();
>> 183: }
>> 184: if (is_set(RISCV_HWPROBE_KEY_IMA_EXT_0, RISCV_HWPROBE_EXT_ZICBOZ)) {
>
> Could you add Zicbop and Zicbom as well? Are they even supported/defined in the kernel headers?
Seems they are not supported in kernel yet, please check https://github.com/torvalds/linux/blob/master/arch/riscv/include/uapi/asm/hwprobe.h.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22474#discussion_r1865795175
More information about the hotspot-dev
mailing list