RFR: 8345179: RISC-V: Add gtests for weak cmpxchg [v3]

[Robbin Ehn]

On Tue, 3 Dec 2024 01:34:40 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added weak 4/8 byte cmpxchg
>
> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 295:
> 
>> 293:     address entry = _masm.pc();
>> 294:     {
>> 295:        _masm.cmpxchg_weak(/*addr*/ c_rarg0, /*expected*/ c_rarg1, /*new_value*/ c_rarg2,
> 
> Seems that we should rename macro-assembler routine `cmpxchg_weak` to `weak_cmpxchg`.
> I have prepared another PR to fix this naming issue: https://github.com/openjdk/jdk/pull/22505.

Ok!

> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 308:
> 
>> 306: 
>> 307: template <typename TESTSIZE, Assembler::operand_size ASMSIZE>
>> 308: void run_narrow_cmpxchg_tests() {
> 
> Consider rename to `run_weak_cmpxchg_narrow_value_tests`.

Fixed

> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 354:
> 
>> 352: 
>> 353: template <typename TESTSIZE, Assembler::operand_size ASMSIZE>
>> 354: void weak_cmpxchg_test() {
> 
> Consider rename to `run_weak_cmpxchg_tests`.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1867159211
PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1867158865
PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1867159033