RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

[Julian Waters]

On Wed, 4 Dec 2024 01:26:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

> So for the sharedRuntime changes, IIUC what was previously only needed for Windows x64 is now only needed for Windows Aarch64 - correct?

Yes, that seems to be the case

> src/hotspot/os/windows/sharedRuntimeRem.cpp line 42:
> 
>> 40: static const double one = 1.0, Zero[] = { 0.0, -0.0, };
>> 41: 
>> 42: double SharedRuntime::fmod_win64(double x, double y)
> 
> Wouldn't `fmod_winAarch64` or `fmod_winARM64` make more sense given this is now only used for Aarch64?

The name was suggested by Andrew, I'll change it to fmod_winarm64 if you prefer

> src/hotspot/share/runtime/sharedRuntime.cpp line 287:
> 
>> 285: 
>> 286: 
>> 287: #ifdef _M_ARM64
> 
> If this is ARM64 only then the `#if !defined(X86)` at line 294 is not needed.

Wouldn't this cause a multiple definition error for frem and drem if the #if !defined(X86) was removed? The #if prevents those 2 methods from being defined when on x86 so it doesn't conflict with the x86 specific definitions, without it frem and drem would be defined twice on x86

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-2516148063
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1868690717
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1868691936