RFR: 8345355: [s390x] support for z16 hardware [v2]
Amit Kumar
amitkumar at openjdk.org
Wed Dec 4 04:34:15 UTC 2024
On Wed, 4 Dec 2024 04:30:47 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> This was the output for `jdk/bin/java -XX:+Verbose --version` command on a z16 hardware:
>>
>>
>> CPU Version as detected internally: system-z, g9-z15, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr, instrext2, venh1, instrext3, venh2, out-of-support_as_of_tbd, aes128, aes192, aes256, sha1, sha256, sha512, ghash
>>
>>
>> So the issue is that z16 should be recognized as g10-z16 but instead I got g9-z15.
>>
>> This is the output with current changes:
>>
>>
>> CPU Version as detected internally: system-z, g10-z16, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr, instrext2, venh1, instrext3, venh2,bear_enh, sort_enh, nnpa_assist, storage_key_removal, vpack_decimal_enh, out-of-support_as_of_tbd, aes128, aes192, aes256, sha1, sha256, sha512, ghash
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Correct NNP Assist Facility Mask
src/hotspot/cpu/s390/vm_version_s390.hpp line 93:
> 91:
> 92: #define BEAREnhFacilityMask 0x4000000000000000UL // z16, BEAR-enhancement facility, Bit: 193
> 93: #define NNPAssistFacilityMask 0x0000000000040000UL // z16, Neural-network-processing-assist facility, Bit: 165
[My script](https://github.com/offamitkumar/s390xFacilityMask) says that this should be
Suggestion:
#define NNPAssistFacilityMask 0x0000000004000000UL // z16, Neural-network-processing-assist facility, Bit: 165
Enter Facility Bit Number: 165
_feature array index: 2
bit position to set: 37
bit string: 0000000000000000000000000000000000000100000000000000000000000000
Mask: 0x0000000004000000UL
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22508#discussion_r1868702977
More information about the hotspot-dev
mailing list