RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

[Julian Waters]

On Wed, 4 Dec 2024 06:08:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The name was suggested by Andrew, I'll change it to fmod_winarm64 if you prefer
>
> I thought at the time the name was because it was for both x64 and aarch64 - hence any win64 platform. But if it is only for Aarch64 then it makes sense to me that the function name conveys that.

Alright, I'll change it

>> Wouldn't this cause a multiple definition error for frem and drem if the #if !defined(X86) was removed? The #if prevents those 2 methods from being defined when on x86 so it doesn't conflict with the x86 specific definitions, without it frem and drem would be defined twice on x86
>
> But if we enter this block because _M_ARM64 is defined then X86 cannot be defined so line 294 is vacuously true.

I'm not sure I follow - The _M_ARM64 block is terminated by an endif before line 294, it is only there to define the global constants and does not guard the code below that line 294 does. Additionally, the code guarded by the if X86 seems to be for all non x86 platforms, not just ARM64

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1868780144
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1868780027