RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Dec 4 19:08:13 UTC 2024


On Wed, 4 Dec 2024 15:47:26 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Please review this small renaming patch. During the review of JDK-8338383 there were some comments about improving the naming for `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate from the changes introduced to inflated monitors, where we now record the `java.lang.Thread.tid` of the owner in the ObjectMonitor's `_owner` field instead of a `JavaThread*`. I renamed `_lock_id` as `_monitor_owner_id` and `owner_from()` as `owner_id_from()`.
>> 
>> Thanks,
>> Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix parameter name

Update looks good!

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22524#pullrequestreview-2479668829


More information about the hotspot-dev mailing list