RFR: 8342769: HotSpot Windows/gcc port is broken [v9]
David Holmes
dholmes at openjdk.org
Thu Dec 5 09:28:44 UTC 2024
On Wed, 4 Dec 2024 06:18:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> But if we enter this block because _M_ARM64 is defined then X86 cannot be defined so line 294 is vacuously true.
>
> I'm not sure I follow - The _M_ARM64 block is terminated by an endif before line 294, it is only there to define the global constants and does not guard the code below that line 294 does. Additionally, the code guarded by the if X86 seems to be for all non x86 platforms, not just ARM64
Apologies somehow the endif at line 292 was invisible
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1870979837
More information about the hotspot-dev
mailing list