RFR: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats [v3]
Lutz Schmidt
lucy at openjdk.org
Thu Dec 5 12:02:37 UTC 2024
On Thu, 28 Nov 2024 21:33:23 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> PPC64 implementation of [JDK-8289552](https://bugs.openjdk.org/browse/JDK-8289552). I've implemented some more instructions which may be useful in the future.
>> VectorCastNodes are not yet implemented on PPC64. Power9 is recognized by the availability of the "darn" instruction.
>>
>> Performance on Power9:
>> Before patch:
>>
>> Benchmark (size) Mode Cnt Score Error Units
>> Fp16ConversionBenchmark.float16ToFloat 2048 thrpt 15 18.995 ? 0.156 ops/ms
>> Fp16ConversionBenchmark.floatToFloat16 2048 thrpt 15 18.730 ? 0.331 ops/ms
>>
>>
>> After patch:
>>
>> Benchmark (size) Mode Cnt Score Error Units
>> Fp16ConversionBenchmark.float16ToFloat 2048 thrpt 15 522.637 ? 11.274 ops/ms
>> Fp16ConversionBenchmark.floatToFloat16 2048 thrpt 15 408.112 ? 9.069 ops/ms
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>
> Make sure interpreter entries are not called on Power8 or older.
LGTM.
-------------
Marked as reviewed by lucy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22433#pullrequestreview-2481473423
More information about the hotspot-dev
mailing list