RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

[David Holmes]

On Thu, 5 Dec 2024 09:55:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Though now I am even more confused. For x64 where are the definitions for `float_sign_mask` etc??
>
> x86 (And by extension x64) uses handwritten assembly to implement this, and as such simply doesn't use float_sign_mask and friends: https://github.com/openjdk/jdk/blob/3b7571d37812472a2152f9c8cbfd2a4abdb35016/src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp#L123

Sorry still struggling to understand what os+cpu combinations will cause this code to be compiled. If not ARM64 and not x64 then where are the definitions for things like `float_sign_mask` used by this seemingly shared code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1872657985