RFR: 8345269: Fix -Wzero-as-null-pointer-constant warnings in ppc code [v2]

Kim Barrett kbarrett at openjdk.org
Fri Dec 6 06:33:27 UTC 2024


> Please review this change to remove -Wzero-as-null-pointer-constant warnings
> in ppc code.
> 
> Most places involve just changing literal 0 to nullptr.
> 
> Removed a dead return after ShouldNotReachHere() that is no longer needed.
> 
> Removed some unused Address constructors that had a default address argument
> with literal 0 as the default value.  These could have been changed to use
> nullptr as the default value, but since they aren't used...
> 
> Testing:
> GHA sanity test build, with and without -Wzero-as-null-pointer-constant enabled.
> I don't have the capability to run tests for this platform, so hoping someone
> from the aix-ppc maintainers can do more testing.

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into fix-ppc-zero-null
 - Merge branch 'master' into fix-ppc-zero-null
 - simple ppc fixes
 - remove unneeded Address ctors

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22466/files
  - new: https://git.openjdk.org/jdk/pull/22466/files/31047fc7..a3941e41

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22466&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22466&range=00-01

  Stats: 85531 lines in 1263 files changed: 69427 ins; 11000 del; 5104 mod
  Patch: https://git.openjdk.org/jdk/pull/22466.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22466/head:pull/22466

PR: https://git.openjdk.org/jdk/pull/22466


More information about the hotspot-dev mailing list