RFR: 8311542: Consolidate the native stack printing code

[David Holmes]

On Fri, 6 Dec 2024 07:54:51 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I passed by reference here just to avoid adding in an additional level of copying in the new code as I was unsure if an additional copy might have an adverse impact. I never considered applying const and I also suspect it will have a significant flow-on effect if I try.
>
> Note that the contents in fr is overwritten in this function. All callers of this function must be careful because of that. I vote for fixing it before pushing this.

@stefank - yes you are right. I think I introduced the reference in an earlier version of the code to avoid introducing an intermediary frame object, but as it stands the frame is passed in directly whereas the original code made a copy. I will fix it. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22472#discussion_r1873307215