RFR: 8311542: Consolidate the native stack printing code [v4]
David Holmes
dholmes at openjdk.org
Tue Dec 10 02:23:23 UTC 2024
> We now print native stacks in a number of contexts, not just VMError reporting, and we have to try `os::platform_print_native_stack` else fall back to `VMError::print_native stack`.
>
> The refactoring adds a new `NativeStackPrinter` (NSP) helper class which can be constructed with some of the context information for the printing that will follow. This avoids the need for the print functions to have a large number of parameters. We have to expose both the top-level printing functionality and the "lower-level" frame-based stack walk as the error reporter needs access to that directly. To maintain the exact same format of output the NSP has to be aware of some error reporter usage requirements.
>
> I also had to expose a direct `frame` taking print function for the Debug.cpp `pns` case.
>
> Testing:
> - tiers 1 - 4
>
> Some frame management code was also moved from `VMError` to the `frame` class.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Fix missing multiple-include guards
Added explicit includes instead of forward decls (trying to track down unrelated Windows build failure)
Fixed indent of assertion
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22472/files
- new: https://git.openjdk.org/jdk/pull/22472/files/a65a1452..cfdb7da0
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22472&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22472&range=02-03
Stats: 13 lines in 1 file changed: 7 ins; 4 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/22472.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22472/head:pull/22472
PR: https://git.openjdk.org/jdk/pull/22472
More information about the hotspot-dev
mailing list