RFR: 8342881: RISC-V: secondary_super_cache does not scale well: C1 and interpreter [v4]

Gui Cao gcao at openjdk.org
Tue Dec 10 07:53:54 UTC 2024


On Tue, 10 Dec 2024 03:41:28 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8342881
>>  - 8342881: RISC-V: secondary_super_cache does not scale well: C1 and interpreter
>
> src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp line 892:
> 
>> 890:                                          nullptr, /*L_success*/
>> 891:                                          &miss    /*L_failure*/);
>> 892: 
> 
> Could you please add a code comment about extra regsiters used for table lookup? We reserve several more in `MacroAssembler::check_klass_subtype_slow_path_table`.

Thanks for your review, and all comments related have been fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21922#discussion_r1877520645


More information about the hotspot-dev mailing list