RFR: 8342769: HotSpot Windows/gcc port is broken [v15]

David Holmes dholmes at openjdk.org
Tue Dec 10 07:53:46 UTC 2024


On Tue, 10 Dec 2024 06:10:28 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 27 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into hotspot
>  - _WINDOWS && AARCH64 in sharedRuntime.hpp
>  - AARCH64 in sharedRuntimeRem.cpp
>  - Refactor sharedRuntime.cpp
>  - CAST_FROM_FN_PTR in os_windows.cpp
>  - Merge branch 'openjdk:master' into hotspot
>  - fmod_winarm64 in sharedRuntime.cpp
>  - fmod_winarm64 in sharedRuntimeRem.cpp
>  - fmod_winarm64 in sharedRuntime.hpp
>  - Typo in sharedRuntimeRem.cpp
>  - ... and 17 more: https://git.openjdk.org/jdk/compare/9e1f0f31...ff1c4664

Marked as reviewed by dholmes (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21627#pullrequestreview-2491326474


More information about the hotspot-dev mailing list