RFR: 8345678: compute_modifiers should not be in create_mirror

[David Holmes]

On Mon, 9 Dec 2024 13:09:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I thought the comment was referring to this code below that late calculates the modifier flags.  Don't know why system dictionary was called out though.
>
> And they're not the same as access flags.

The "recalculate" is what is throwing me - that suggests the flags were already "calculated" somewhere. Does it really mean just "calculate" and that we do it between parsing and adding to SD? (Not that I know what the significance of that placement is meant to be.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1877642184