RFR: 8345658: WB_NMTCommitMemory redundantly records an NMT tag

Tue Dec 10 09:51:38 UTC 2024

On Fri, 6 Dec 2024 10:09:02 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> This functions is called after an previous calls to WB_NMTReserveMemory and WB_NMTAttemptReserveMemoryAt, which both already registered an NMT tag. So, explicitly recording an NMT tag for this memory is redundant and slightly confusing.
> 
> The HotSpot JVM code does not record NMT tags when committing memory (except in a special case on Windows when mapping file memory).
> 
> Tested with tier1-3.

Seems correct to me.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22601#pullrequestreview-2491711205