RFR: 8345273: Fix -Wzero-as-null-pointer-constant warnings in s390 code [v3]

Kim Barrett kbarrett at openjdk.org
Tue Dec 10 16:19:39 UTC 2024


On Tue, 10 Dec 2024 16:16:57 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to remove -Wzero-as-null-pointer-constant warnings
>> in s390 code.
>> 
>> Most places involve just changing literal 0 to nullptr.
>> 
>> Removed a dead return after ShouldNotReachHere() that is no longer needed.
>> 
>> Testing:
>> GHA sanity test build, with and without -Wzero-as-null-pointer-constant enabled.
>> I don't have the capability to run tests for this platform, so hoping someone
>> from the aix-ppc maintainers can do more testing.
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into fix-s390-zero-null
>  - Merge branch 'master' into fix-s390-zero-null
>  - simple s390 fixes

I'd like a review from an s390 porter.  But it's a simple enough change that I'm not going to wait indefinitely.
I'll give it another day.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22469#issuecomment-2532189894


More information about the hotspot-dev mailing list