RFR: 8345269: Fix -Wzero-as-null-pointer-constant warnings in ppc code [v3]

Kim Barrett kbarrett at openjdk.org
Tue Dec 10 16:21:22 UTC 2024


> Please review this change to remove -Wzero-as-null-pointer-constant warnings
> in ppc code.
> 
> Most places involve just changing literal 0 to nullptr.
> 
> Removed a dead return after ShouldNotReachHere() that is no longer needed.
> 
> Removed some unused Address constructors that had a default address argument
> with literal 0 as the default value.  These could have been changed to use
> nullptr as the default value, but since they aren't used...
> 
> Testing:
> GHA sanity test build, with and without -Wzero-as-null-pointer-constant enabled.
> I don't have the capability to run tests for this platform, so hoping someone
> from the aix-ppc maintainers can do more testing.

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into fix-ppc-zero-null
 - Merge branch 'master' into fix-ppc-zero-null
 - Merge branch 'master' into fix-ppc-zero-null
 - simple ppc fixes
 - remove unneeded Address ctors

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22466/files
  - new: https://git.openjdk.org/jdk/pull/22466/files/a3941e41..2a35f20d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22466&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22466&range=01-02

  Stats: 3117 lines in 1457 files changed: 960 ins; 887 del; 1270 mod
  Patch: https://git.openjdk.org/jdk/pull/22466.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22466/head:pull/22466

PR: https://git.openjdk.org/jdk/pull/22466


More information about the hotspot-dev mailing list