RFR: 8342881: RISC-V: secondary_super_cache does not scale well: C1 and interpreter [v5]

[Fei Yang]

On Tue, 10 Dec 2024 07:53:52 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> Follow this patch https://github.com/openjdk/jdk/pull/19989, The fix for [JDK-8332587](https://bugs.openjdk.org/browse/JDK-8332587) was for C2 only. Implement the same fix for C1 and the interpreter.
>> 
>> ### Testing
>> - [x] Run tier1-3 tests on SOPHON SG2042 (release)
>
> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update for RealFYang's comment

Overall LGTM modulo two minor comments. Maybe we can get a review from the original author of the work? @theRealAph

src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 4360:

> 4358:                                     tmp4_reg, nullptr);
> 4359: 
> 4360:   // We will Unspill the tmp registers, so we should mark the result_reg to t1.

Suggestion about the code comment: `// Move the result to t1 as we are about to unspill the tmp registers.`

src/hotspot/cpu/riscv/riscv.ad line 2367:

> 2365:     Label done;
> 2366:     __ check_klass_subtype_slow_path(sub_reg, super_reg, temp_reg, result_reg,
> 2367:                                      nullptr, &miss, true /*set_cond_codes:*/);

Suggestion about the code comment: `nullptr, &miss, /*set_cond_codes*/ true);`

-------------

PR Review: https://git.openjdk.org/jdk/pull/21922#pullrequestreview-2494453862
PR Review Comment: https://git.openjdk.org/jdk/pull/21922#discussion_r1879460539
PR Review Comment: https://git.openjdk.org/jdk/pull/21922#discussion_r1879434221