RFR: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants [v2]

Robbin Ehn rehn at openjdk.org
Wed Dec 11 09:20:16 UTC 2024


On Wed, 11 Dec 2024 03:17:06 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Code share
>>  - Overflow
>>  - Merge branch 'master' into 8345322
>>  - Concurrent
>
> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 375:
> 
>> 373: template<>
>> 374: constexpr int64_t result_count<int64_t>() {
>> 375:     return std::numeric_limits<int64_t>::min() + TOTAL_ITERATIONS;
> 
> There is an indentation issue for this line. Maybe we can specialize `int32_t` as well?

I wanted to cover when adding uint32.
Used enbaled if instead and added uint32.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22574#discussion_r1879674532


More information about the hotspot-dev mailing list