RFR: 8345269: Fix -Wzero-as-null-pointer-constant warnings in ppc code [v3]

[Matthias Baesken]

On Tue, 10 Dec 2024 16:21:22 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to remove -Wzero-as-null-pointer-constant warnings
>> in ppc code.
>> 
>> Most places involve just changing literal 0 to nullptr.
>> 
>> Removed a dead return after ShouldNotReachHere() that is no longer needed.
>> 
>> Removed some unused Address constructors that had a default address argument
>> with literal 0 as the default value.  These could have been changed to use
>> nullptr as the default value, but since they aren't used...
>> 
>> Testing:
>> GHA sanity test build, with and without -Wzero-as-null-pointer-constant enabled.
>> I don't have the capability to run tests for this platform, so hoping someone
>> from the aix-ppc maintainers can do more testing.
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into fix-ppc-zero-null
>  - Merge branch 'master' into fix-ppc-zero-null
>  - Merge branch 'master' into fix-ppc-zero-null
>  - simple ppc fixes
>  - remove unneeded Address ctors

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22466#pullrequestreview-2496422912