RFR: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants [v4]
Hamlin Li
mli at openjdk.org
Thu Dec 12 09:49:41 UTC 2024
On Wed, 11 Dec 2024 09:26:13 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider these additional concurrent tests.
>>
>> (this will not go into 24)
>>
>> There are two concurrent counter versions:
>> - Each thread is exclusively responsible for an certain increment steps
>> - Each thread plainly tries to CAS increment by one
>>
>> I refactored the code, so these concurrent versions can reuse the generated CAS functions.
>>
>>
>> [ RUN ] RiscV.cmpxchg_int64_concurrent_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int64_concurrent_lr_sc_vm (24 ms)
>> [ RUN ] RiscV.cmpxchg_int64_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int64_concurrent_maybe_zacas_vm (12 ms)
>> [ RUN ] RiscV.cmpxchg_int32_concurrent_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int32_concurrent_lr_sc_vm (14 ms)
>> [ RUN ] RiscV.cmpxchg_int32_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int32_concurrent_maybe_zacas_vm (14 ms)
>> [ RUN ] RiscV.cmpxchg_int16_concurrent_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int16_concurrent_lr_sc_vm (15 ms)
>> [ RUN ] RiscV.cmpxchg_int16_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int16_concurrent_maybe_zacas_vm (14 ms)
>> [ RUN ] RiscV.cmpxchg_int8_concurrent_lr_sc_vm
>> [ OK ] RiscV.cmpxchg_int8_concurrent_lr_sc_vm (14 ms)
>> [ RUN ] RiscV.cmpxchg_int8_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.cmpxchg_int8_concurrent_maybe_zacas_vm (14 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int64_concurrent_lr_sc_vm
>> [ OK ] RiscV.weak_cmpxchg_int64_concurrent_lr_sc_vm (15 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int64_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.weak_cmpxchg_int64_concurrent_maybe_zacas_vm (11 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int32_concurrent_lr_sc_vm
>> [ OK ] RiscV.weak_cmpxchg_int32_concurrent_lr_sc_vm (15 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int32_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.weak_cmpxchg_int32_concurrent_maybe_zacas_vm (12 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int16_concurrent_lr_sc_vm
>> [ OK ] RiscV.weak_cmpxchg_int16_concurrent_lr_sc_vm (13 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int16_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.weak_cmpxchg_int16_concurrent_maybe_zacas_vm (14 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int8_concurrent_lr_sc_vm
>> [ OK ] RiscV.weak_cmpxchg_int8_concurrent_lr_sc_vm (13 ms)
>> [ RUN ] RiscV.weak_cmpxchg_int8_concurrent_maybe_zacas_vm
>> [ OK ] RiscV.weak_cmpxchg_int8_concurrent_maybe_zacas_vm (15 ms)
>>
>>
>> Execute with +UseZacas, and without on BPI-F3.
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Inclusive case
Nice work. Thanks!
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22574#pullrequestreview-2498661788
More information about the hotspot-dev
mailing list