RFR: 8346082: Output JVMTI agent information is hserr files

David Holmes dholmes at openjdk.org
Thu Dec 12 11:37:39 UTC 2024


On Thu, 12 Dec 2024 09:42:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> We should output more information about the JVMTI agents in the hserr file.

src/hotspot/share/runtime/os.cpp line 1153:

> 1151: #else
> 1152:   st->print_cr("JVMTI support not included in this JVM.");
> 1153: #endif

This is unreachable given the caller is already guarded. It is also unnecessary to report this.

src/hotspot/share/utilities/vmError.cpp line 1279:

> 1277: 
> 1278: #if INCLUDE_JVMTI
> 1279:   STEP_IF("printing jvmti agent infos", _verbose)

Suggestion:

  STEP_IF("printing jvmti agent info", _verbose)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22706#discussion_r1881898451
PR Review Comment: https://git.openjdk.org/jdk/pull/22706#discussion_r1881898831


More information about the hotspot-dev mailing list