RFR: 8345959: Make JVM_IsStaticallyLinked JVM_LEAF

Thu Dec 12 22:37:38 UTC 2024

On Thu, 12 Dec 2024 16:14:31 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Thanks for the quick review, @magicus!
>> 
>> I didn't catch this details while reviewing https://github.com/openjdk/jdk/commit/a136a85b6f5bbc92727883693c1ce31c37a82fd5 either.
>
>> @jianglizhou please remember the two reviewer rule for hotspot changes and the 24 hour rule for non-trivial changes. When Magnus admits to not knowing the significance of leaf versus non-leaf his one review hardly seems sufficient in any case.
>> 
>> The change to leaf is of course fine.
> 
> @dholmes-ora Thanks for the notes. I handled the change as trivial change. I will observe&follow the hotspot change rule more strictly moving forward.

@jianglizhou For a change to be trivial, you need a reviewer to say so.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22685#issuecomment-2540145436