RFR: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants [v6]

Robbin Ehn rehn at openjdk.org
Fri Dec 13 08:05:14 UTC 2024


On Fri, 13 Dec 2024 04:36:39 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Fixed max->min
>>  - Merge branch 'master' into 8345322
>>  - Merge branch 'master' into 8345322
>>  - Fixed tests for uint32 and added edges cases
>>  - Inclusive case
>>  - Reviews comments, added uint32
>>  - Code share
>>  - Overflow
>>  - Merge branch 'master' into 8345322
>>  - Concurrent
>
> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 201:
> 
>> 199: static void run_plain_cmpxchg_tests() {
>> 200:   TESTSIZE max = std::numeric_limits<TESTSIZE>::max();
>> 201:   TESTSIZE min = std::numeric_limits<TESTSIZE>::max();
> 
> Should this be: `TESTSIZE min = std::numeric_limits<TESTSIZE>::min();`?

Yes! Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22574#discussion_r1883516378


More information about the hotspot-dev mailing list