RFR: 8345911: Enhance error message when IncompatibleClassChangeError is thrown for sealed class loading failures [v4]

[David Holmes]

On Mon, 16 Dec 2024 22:39:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update messages per feedback from Alan
>
> src/hotspot/share/classfile/classFileError.cpp line 97:
> 
>> 95: void ClassFileParser::classfile_icce_error(const char* msg,
>> 96:                                            TRAPS) const {
>> 97:   ResourceMark rm(THREAD);
> 
> I don't know what this ResourceMark does since you allocate resources in the caller, not here.

It follows the same pattern as all the other throwing methods - the RM is for the `_class_name->as_C_string()`. I think you may be right that it is the callers that should have the RM. Can I file a follow up RFE to look at that?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22703#discussion_r1887863344