RFR: 8345911: Enhance error message when IncompatibleClassChangeError is thrown for sealed class loading failures [v4]

[David Holmes]

On Mon, 16 Dec 2024 22:39:41 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update messages per feedback from Alan
>
> I just had a couple of stylistic requested changes.  The option you picked - passing in stringStream - is better than the other two options.  Also a question about ResourceMarks.

Thanks for looking at this @coleenp !

> src/hotspot/share/classfile/classFileParser.cpp line 4068:
> 
>> 4066: 
>> 4067:     if (super_ik->is_sealed()) {
>> 4068:       stringStream ss;
> 
> Seems like the ResourceMark belongs here above the has_as_permitted_subclass call as the as_C_string() functions are called in there.  Not in the classfile_icce_error.

Ah yes, in this case that is true. Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22703#issuecomment-2547464179
PR Review Comment: https://git.openjdk.org/jdk/pull/22703#discussion_r1887866863