RFR: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

Chris Plummer cjplummer at openjdk.org
Tue Dec 17 21:44:36 UTC 2024


On Tue, 17 Dec 2024 21:01:51 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the specified FramePop event was already requested. This makes it consistent with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to add a breakpoint request that was already requested.
> 
> CSR: [8346460](https://bugs.openjdk.org/browse/JDK-8346460): NotifyFramePop should return JVMTI_ERROR_DUPLICATE
> 
> Testing:
>  - tested with mach5 tiers 1-6

src/hotspot/share/prims/jvmti.xml line 3088:

> 3086:         </error>
> 3087:         <error id="JVMTI_ERROR_DUPLICATE">
> 3088:           There is already frame pop event request at the specified depth.

Suggestion:

          There is already a frame pop event request at the specified depth.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22798#discussion_r1889263242


More information about the hotspot-dev mailing list