RFR: 8346193: Test runtime/ErrorHandling/TestDwarf.java fails build with clang17 [v2]
SendaoYan
syan at openjdk.org
Wed Dec 18 12:59:39 UTC 2024
On Wed, 18 Dec 2024 09:47:23 GMT, Hamlin Li <mli at openjdk.org> wrote:
> the current fix depends on the internal implementation and the effect of a compilation flag of clang, this is not stable
I don't think the current fix is not stable. According the cppreference documentation:
1. [volatile accesses cannot be optimized out](https://en.cppreference.com/w/cpp/language/cv)
2. [Accesses (reads and writes) to volatile objects occur strictly according to the semantics of the expressions in which they occur.](https://en.cppreference.com/w/cpp/language/as_if)
> seems the test does not check the crash details
Yes, use `ShouldNotReachHere();` instead of `*t = 'c';`, the test still run passed which tested jdk build from gcc. From this perspective, use `ShouldNotReachHere();` also acceptable.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22757#issuecomment-2551257350
More information about the hotspot-dev
mailing list