RFR: 8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases [v5]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Dec 19 04:58:42 UTC 2024


On Thu, 19 Dec 2024 00:09:38 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: removed unneeded check for JvmtiExport::can_post_frame_pop()
>
> src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 79:
> 
>> 77:     _pops->remove_at(idx);
>> 78:   }
>> 79:   assert(_pops->length() == 0, "sanity check");
> 
> Suggestion:
> 
>   _pops->clear();

Good suggestion, thanks. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22744#discussion_r1891155240


More information about the hotspot-dev mailing list