RFR: 8346602: Remove unused macro parameters in `jni.cpp`
Qizheng Xing
qxing at openjdk.org
Fri Dec 20 08:58:45 UTC 2024
On Thu, 19 Dec 2024 21:05:25 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Some of the macros in `jni.cpp`, including `DEFINE_GETSCALARARRAYELEMENTS`, `DEFINE_RELEASESCALARARRAYELEMENTS`, `DEFINE_GETSCALARARRAYREGION` and `DEFINE_SETSCALARARRAYREGION`, have unused parameters.
>>
>> This patch removes them.
>
> Wow - how did you spot that? These parameters have been unused since the day the code was added!
>
> LGTM.
>
> Thanks
@dholmes-ora Thanks for your review!
> Wow - how did you spot that? These parameters have been unused since the day the code was added!
I was trying to work on JNI related implementations recently, and just happened to find this 😂.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22824#issuecomment-2556555179
More information about the hotspot-dev
mailing list