RFR: 8346123: [REDO] NMT should not use ThreadCritical [v6]

Robert Toyonaga duke at openjdk.org
Fri Dec 20 17:53:16 UTC 2024


On Thu, 19 Dec 2024 22:43:39 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert to using NmtVirtualMemoryLocker. Use defaultStream. Add comment for SharedDecoder_lock
>
> src/hotspot/share/nmt/memTracker.hpp line 285:
> 
>> 283:       ConditionalMutexLocker _cml;
>> 284:   public:
>> 285:       NmtVirtualMemoryLocker(): _cml(NmtVirtualMemory_lock, _done_bootstrap, Mutex::_no_safepoint_check_flag){}
> 
> Indented 4, but HotSpot style is indent 2.

Updated. Thank you!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894224351


More information about the hotspot-dev mailing list