RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v2]

Boris Ulasevich bulasevich at openjdk.org
Thu Feb 1 11:35:07 UTC 2024


On Tue, 16 Jan 2024 18:24:17 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   cleanup & test udpdate
>
> src/hotspot/share/code/codeCache.hpp line 120:
> 
>> 118:     return (cache_size > known_segments_size + min_size) ? (cache_size - known_segments_size) : min_size;
>> 119:   }
>> 120: 
> 
> Do we need them in `CodeCache` class and in the hpp file?
> Why not to have them as static functions in the cpp file? In such a case there will to expose the `CodeCacheSegment` struct.

OK

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1474300355


More information about the hotspot-dev mailing list