RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v3]

[Daniel D. Daugherty]

On Thu, 1 Feb 2024 14:09:04 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/share/runtime/synchronizer.cpp line 449:
>> 
>>> 447: 
>>> 448: // Handle notifications when synchronizing on value based classes
>>> 449: void ObjectSynchronizer::handle_sync_on_value_based_class(Handle obj, JavaThread* locking_thread) {
>> 
>> Can we add a comment (or even repeat the assertion) that locking thread is either the current thread or a suspended thread, please. This method performs a  number of actions that are not safe to make on an arbitrary thread.
>
> I breezed right by this function... where did that come from?

Sorry, rhetorical question. I can figure out where it came from (and how I missed seeing it).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17626#discussion_r1474544439