RFR: 8324983: race in CompileBroker::possibly_add_compiler_threads [v2]

[Tom Rodriguez]

On Thu, 1 Feb 2024 07:07:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Convert guarantee to assert
>
> src/hotspot/share/runtime/javaThread.cpp line 748:
> 
>> 746:   // to complete once we've done the notify_all below. Needs a release() to obey Java Memory Model
>> 747:   // requirements.
>> 748:   guarantee(java_lang_Thread::thread(threadObj()) == thread, "must be alive");
> 
> Please make this an assert rather than a guarantee. Only compiler threads can potentially violate this so we should not pay the price of the check for every thread .

Ok.  It's not exactly an expensive test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17662#discussion_r1474848832